Skip to content

Support audio devices with more than 2 channels #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

probonopd
Copy link

@probonopd probonopd commented Jul 13, 2025

Currently they don't even show up in the sound device selector. With this, they do. Tested with a BOSE Companion 5 (USB) but likely this will also work for USB audio interfaces with more than 2 channels.

Possibly the number should be increased even further, so that audio interfaces with even more channels would work.

References:

@probonopd probonopd requested review from a team as code owners July 13, 2025 18:05
@ghostbsd-bot
Copy link

Can one of the admins verify this patch?

Copy link

sourcery-ai bot commented Jul 13, 2025

Reviewer's Guide

Adds a sysctl configuration entry to enable USB audio devices with more than two channels by setting the default to six channels.

Flow diagram for audio device channel configuration update

flowchart TD
    A[Boot or sysctl reload] --> B[Read sysctl.conf]
    B --> C[Set hw.usb.uaudio.default_channels=6]
    C --> D[Audio subsystem allows devices with >2 channels]
Loading

File-Level Changes

Change Details Files
Enable support for USB audio devices with more than two channels
  • Added a comment clarifying the new multi-channel audio support
  • Inserted hw.usb.uaudio.default_channels=6 setting
sbin/sysctl/sysctl.conf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Thank you for taking the time to contribute to FreeBSD!
There are a few issues that need to be fixed:

  • Missing Signed-off-by linese74d0a7
  • Real email address is needede74d0a7

Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Management Jul 13, 2025
@probonopd
Copy link
Author

The build error looks unrelated to this PR.

@ericbsd
Copy link
Member

ericbsd commented Jul 14, 2025

Most of these are FreeBSD-related, nothing to worry about.

@ericbsd ericbsd merged commit a5ab4c1 into ghostbsd:main Jul 14, 2025
6 of 12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Management Jul 14, 2025
@probonopd
Copy link
Author

Thank you very much @ericbsd

@ericbsd
Copy link
Member

ericbsd commented Jul 14, 2025

@probonopd are you planning to backport to releng/14.3?

@probonopd probonopd deleted the patch-2 branch July 14, 2025 20:28
@probonopd
Copy link
Author

probonopd commented Jul 14, 2025

I can submit PR(s) for releng/14.3. Do you prefer two separate PRs for

or one combined one?

@ericbsd
Copy link
Member

ericbsd commented Jul 15, 2025

I can submit PR(s) for releng/14.3. Do you prefer two separate PRs for

* [Automatic sound switching #369](https://github.com/ghostbsd/ghostbsd-src/pull/369)

* [Support audio devices with more than 2 channels #370](https://github.com/ghostbsd/ghostbsd-src/pull/370)

or one combined one?

One PR is fine.

probonopd added a commit to probonopd/ghostbsd-src that referenced this pull request Jul 16, 2025
ericbsd added a commit that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants