-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix footnote jump behavior on the issue page. #34621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+92
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11b5171
to
a322a88
Compare
lunny
reviewed
Jun 6, 2025
It's better to have a test. |
Related to #34590 |
a322a88
to
98eb32c
Compare
1c232e4
to
ff9efed
Compare
lunny
reviewed
Jun 7, 2025
ff9efed
to
f8de6b0
Compare
lunny
previously approved these changes
Jun 9, 2025
To make backport easier, maybe we can use this approach temporarily, will make some new changes. |
wxiaoguang
approved these changes
Jun 9, 2025
lunny
approved these changes
Jun 9, 2025
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 9, 2025
Close go-gitea#34511 Close go-gitea#34590 Add comment ID to the footnote item's id attribute to ensure uniqueness. --------- Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/done
All backports for this PR have been created
backport/v1.24
This PR should be backported to Gitea 1.24
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/frontend
modifies/go
Pull requests that update Go code
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #34511
Close #34590
Add comment ID to the footnote item's id attribute to ensure uniqueness.