Skip to content

Conversation

coolwednesday
Copy link
Member

@coolwednesday coolwednesday commented Sep 5, 2025

  • Currently, we are using Overload for overriding. This causes the system environment variables to be overwritten. To handle this, we now run a manual loop that skips all environment variables initially loaded from the system.

@Umang01-hash
Copy link
Member

@coolwednesday I feel the code can be refactored into a simpler implementation. The three file loading functions (loadBaseEnvFile, loadLocalOverrideFile, loadEnvSpecificFile) contain significant duplication - consider creating a generic loadEnvFile function that handles common loading logic and error handling.

@coolwednesday coolwednesday changed the title Fix config reading & its tests Fix config Overloading & its tests Sep 8, 2025
@coolwednesday
Copy link
Member Author

@aryanmehrotra, Here is the running tested server :
Screenshot 2025-09-08 at 4 30 49 PM

@aryanmehrotra aryanmehrotra merged commit 5152074 into gofr-dev:development Sep 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants