Skip to content

fix(dependencies): removing versions ceilings on tokenizers and huggingface_hub dependencies #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CarolinePascal
Copy link
Collaborator

@CarolinePascal CarolinePascal commented Jul 28, 2025

What this does

Removing ceiling versions on tokenizers and huggingface_hub dependencies after patch release and wheels publication.

How it was tested

N/A

How to checkout & try? (for the reviewer)

N/A

Copy link
Member

@AdilZouitine AdilZouitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michel-aractingi michel-aractingi marked this pull request as ready for review July 29, 2025 08:36
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 08:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes version ceiling constraints on the tokenizers and huggingface_hub dependencies as part of a maintenance update following a patch release and wheels publication.

  • Removes upper bound constraint on huggingface-hub dependency and updates minimum version to 0.34.2
  • Removes tokenizers dependency constraint from the transformers-dep optional dependency group
Comments suppressed due to low confidence (1)

pyproject.toml:64

  • The version 0.34.2 for huggingface-hub may not exist. As of my knowledge cutoff in January 2025, huggingface-hub versions typically follow a different numbering scheme. Please verify this version exists on PyPI before merging.
    "huggingface-hub[hf-transfer,cli]>=0.34.2",

@CarolinePascal CarolinePascal merged commit c14ab9e into main Jul 29, 2025
11 checks passed
@CarolinePascal CarolinePascal deleted the user/CarolinePascal/2025-07-28-bumb-dependencies branch July 29, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants