Update offset-buffer.js #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UInt8 read and write
| @@ -69,6 +74,12 @@ module.exports = function(ref, int24, logger) { | |||
| this.read_offset += 1; | |||
| return result; | |||
| }; | |||
|
|
|||
| OffsetBuffer.prototype.readUInt8() = function() { | |||
There was a problem hiding this comment.
"readUInt8() = " is not valid. You maybe wanted just "readUInt = " ?
There was a problem hiding this comment.
Sorry, made a couple of errors in process, meant to add functions http://nodejs.org/api/buffer.html#buffer_buf_readuint8_offset_noassert
http://nodejs.org/api/buffer.html#buffer_buf_writeuint8_value_offset_noassert
(since Node v0.5.5)
There was a problem hiding this comment.
Yep. It should pass the provided unit tests, so try to get it to that state first.
|
Ok, i've corrected it to pass tests and added tests for new functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UInt8 read and write