Skip to content

Update offset-buffer.js #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update offset-buffer.js #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2d80e8
Update offset-buffer.js
scythianfuego Oct 16, 2014
c6f5778
Unsigned Int8 read/write (corrected typos)
scythianfuego Oct 17, 2014
2113e39
Test readUInt8/writeUInt8
scythianfuego Dec 17, 2014
db39ff2
Corrected a typo
scythianfuego Dec 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion offset-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ module.exports = function(ref, int24, logger) {
this.buf.writeInt8(value, this.write_offset);
this.write_offset += 1;
};

OffsetBuffer.prototype.writeUInt8 = function(value) {
this.buf.writeUInt8(value, this.write_offset);
this.write_offset += 1;
};

OffsetBuffer.prototype.writeInt16BE = function(value) {
this.buf.writeInt16BE(value, this.write_offset);
Expand Down Expand Up @@ -69,6 +74,12 @@ module.exports = function(ref, int24, logger) {
this.read_offset += 1;
return result;
};

OffsetBuffer.prototype.readUInt8 = function() {
var result = this.buf.readUInt8(this.read_offset);
this.read_offset += 1;
return result;
};

OffsetBuffer.prototype.readInt16BE = function() {
var result = this.buf.readInt16BE(this.read_offset);
Expand Down Expand Up @@ -251,4 +262,4 @@ module.exports = function(ref, int24, logger) {
};

return OffsetBuffer;
};
};
26 changes: 16 additions & 10 deletions test/offset-buffer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ test('writeInt8', function(t) {
t.end();
});

test('writeUInt8', function(t) {
var b = new OffsetBuffer(1);
b.writeUInt8(0xfe);
t.equal(b.buf[0], 0xfe, 'writeUInt8: Written data matches');
t.equal(b.write_offset, 1, 'writeUInt8: write offset correct');
t.end();
});

test('writeInt16BE', function(t) {
var b = new OffsetBuffer(2);
b.writeInt16BE(0x04);
Expand Down Expand Up @@ -176,6 +184,14 @@ test('readInt8', function(t) {
t.end();
});

test('readUInt8', function(t) {
var b = new OffsetBuffer([0xfe]);
t.equal(b.readUInt8(), 0xfe, 'readInt8: Read data matches');
t.equal(b.read_offset, 1, 'readInt8: read offset correct');
t.end();
});


test('readInt16BE', function(t) {
var b = new OffsetBuffer([0x04, 0x05]);
t.equal(b.readInt16BE(), 1029, 'readInt16BE: Read data matches');
Expand Down Expand Up @@ -342,13 +358,3 @@ test('copyTo', function(t) {
t.equal(from.read_offset, 5, 'copyTo: read offset at the end of the buffer');
t.end();
});