[serde_multipart] serializable Message
#852
Closed
+72
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! [ghstack-poisoned]
This was referenced Aug 13, 2025
mariusae
added a commit
that referenced
this pull request
Aug 13, 2025
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! ghstack-source-id: 302736715 Pull Request resolved: #852
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80179921 |
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80179921 |
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! [ghstack-poisoned]
This was referenced Aug 18, 2025
|
This pull request was exported from Phabricator. Differential Revision: D80179921 |
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80179921 |
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303723936 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303723936 Reviewed By: shayne-fletcher Differential Revision: D80179921
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80179921 |
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 303814002 Reviewed By: shayne-fletcher Differential Revision: D80179921
We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. Differential Revision: [D80179921](https://our.internmc.facebook.com/intern/diff/D80179921/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80179921/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80179921 |
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: We want to be able to (efficiently) serialize `Message`, passing through its constituent parts; and also to treat the message body as its own part. In this change, we derive `Serialize` for `Message`, and convert its body into a `Part`. ghstack-source-id: 304032338 Reviewed By: shayne-fletcher Differential Revision: D80179921
|
This pull request has been merged in ed701b1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Message#852We want to be able to (efficiently) serialize
Message, passing through its constituent parts; and also to treat the message body as its own part.In this change, we derive
SerializeforMessage, and convert its body into aPart.Differential Revision: D80179921
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!