[serde_multipart] framed multipart encoding #876
Closed
+168
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. Differential Revision: [D80262357](https://our.internmc.facebook.com/intern/diff/D80262357/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80262357/)! [ghstack-poisoned]
This was referenced Aug 14, 2025
meta-cla
bot
added
the
CLA Signed
mariusae
added a commit
that referenced
this pull request
Aug 14, 2025
This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. Differential Revision: [D80262357](https://our.internmc.facebook.com/intern/diff/D80262357/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80262357/)! ghstack-source-id: 303015121 Pull Request resolved: #876
|
This pull request was exported from Phabricator. Differential Revision: D80262357 |
This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. Differential Revision: [D80262357](https://our.internmc.facebook.com/intern/diff/D80262357/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80262357/)! [ghstack-poisoned]
This was referenced Aug 18, 2025
|
This pull request was exported from Phabricator. Differential Revision: D80262357 |
This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. Differential Revision: [D80262357](https://our.internmc.facebook.com/intern/diff/D80262357/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80262357/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80262357 |
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303723938 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303723938 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. Differential Revision: [D80262357](https://our.internmc.facebook.com/intern/diff/D80262357/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80262357/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80262357 |
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 303813998 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. Differential Revision: [D80262357](https://our.internmc.facebook.com/intern/diff/D80262357/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D80262357/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D80262357 |
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
shayne-fletcher
pushed a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages. We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available. ghstack-source-id: 304032341 Reviewed By: shayne-fletcher, vidhyav Differential Revision: D80262357
|
This pull request has been merged in 6487c07. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Message#852This change implements a framed multipart encoding for serde_multipart messages. This represents a common and convenient transport encoding for these messages.
We implement this as a buffer with a specialized vectored IO implementation, allowing the transport to use vectored IO if available.
Differential Revision: D80262357
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!