-
Notifications
You must be signed in to change notification settings - Fork 0
1721 restrict editing to certain submission statuses #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… add banner informing submitter, change button to indicate read only, no extra pop ups, if status updatesrequired and edits made on UI make status inprogress
…already has an issue (reopening if closed)
… and for github comment creation
UpdatesRequired
submission statusThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I was not able to do any functional testing for the github endpoint, but tests of the submission portal components looked good. I had a few minor code comments is all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall.
As I was testing I noticed that I wasn't seeing the status automatically change from UpdatesRequired
to InProgress
. I could see that the InProgress
status was part of the PATCH /api/metadata_submission/{id}
request, but the response still had UpdatesRequired
in it. I think the source of that bug is in the update_submission
route handler function gates the status change on checking if the logged-in user has role of owner on the submission. In my case I was editing someone else's submission as an admin. It's an edge case, but it might be good to clean that up now as we start making more extensive use of statuses.
…l be accomplished in followup pr
…ssion id anywhere in the title or body (ignoring possible formatting changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from a totally non technical perspective.
The description's expected behaviors are accurate.
this PR closes issue #1721. NOTE: to be merged in alongside PR #[tbd] that will enable drop down menu for status changes
Currently, a submission can continue to be edited after hitting the Submit button and there is no functionality to the
UpdatesRequired
submission status.Updates:
InProgress
orUpdatesRequired
SubmittedPendingReview
)InProgress
orUpdatesRequired
Resume
button now saysView
with an eye symbolUpdatesRequired
and edits are made, the status becomesInProgress
againUpdatesRequired
after review via a yet to be implemented drop downNote: status does not change from 'InProgress' to 'UpdatesRequired' if admin makes edits, this is intentional