[WEBRTCR] Send command to DUT via websocket in CI (#41486) #41829
+174
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WEBRTCR] Send command to DUT via websocket in CI * Update src/python_testing/TC_WEBRTCR_2_2.py Co-authored-by: Copilot <[email protected]> * Update src/python_testing/TC_WEBRTCR_2_6.py Co-authored-by: Copilot <[email protected]> * Update src/python_testing/TC_WEBRTCR_2_7.py Co-authored-by: Copilot <[email protected]> * Restyled by autopep8 * Restyled by isort * Address review comments --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Restyled.io <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a WEBRTCRTestBase class to centralize sending commands to the DUT via WebSockets in CI, which is a great improvement for code reuse and maintainability. The individual test cases are updated to leverage this new base class, enabling CI for these WebRTC tests. My review has identified a recurring critical issue across multiple test files where a blocking wait() call is used within an async function. This will block the asyncio event loop and can cause tests to hang. I have provided comments and suggestions in each affected file to resolve this by using run_in_executor.
|
PR #41829: Size comparison from ab13593 to b413026 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Nov 6, 2025
There was a problem hiding this comment.
Seems ok, however @yufengwangca the bot has some comments ... could you confirm if that operation is blocking or not?
chulspro
approved these changes
Nov 7, 2025
pidarped
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WEBRTCR] Send command to DUT via websocket in CI
Update src/python_testing/TC_WEBRTCR_2_2.py
Update src/python_testing/TC_WEBRTCR_2_6.py
Update src/python_testing/TC_WEBRTCR_2_7.py
Restyled by autopep8
Restyled by isort
Address review comments
Summary
Cherry pick [WEBRTCR] Send command to DUT via websocket in CI (#41486)
Related issues
N/A
Testing
Validate by CI