fix download-artifact script #1647

dhchandw · 2025-09-16T23:01:30Z

ZAPP-1662

gemini-code-assist

Summary of Changes

Hello @dhchandw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with the download-artifact script by ensuring that GitHub API calls are consistently authenticated using the provided token. It also adjusts the ESLint configuration to exclude a specific TypeScript file from linting, streamlining the development process.

Highlights

Authentication Fixes: The download-artifact script has been updated to correctly pass the githubToken in the authorization headers for both axios and Octokit requests when interacting with the GitHub API. This addresses issues where the token might not have been properly utilized for authentication.
ESLint Configuration Update: The .eslintrc.js configuration has been modified to ignore the src-script/download-artifact.ts file, preventing linting errors for this specific TypeScript file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request fixes an issue with downloading artifacts by correctly adding authentication tokens to GitHub API requests for both axios and octokit. The changes appear to correctly address unauthenticated API access issues. I have one suggestion to refactor the octokit authentication to be more idiomatic and to remove a potentially confusing code comment. The change to ignore the download script in the ESLint configuration is also appropriate for a standalone script.

src-script/download-artifact.ts

tecimovic

Generally having a file with a same name and a .js and .ts ending sounds like an absolutely terrible idea. Why are we doing this?

Will the TS not simply overwrite the JS once it transpiles?

.eslintrc.js

dhchandw · 2025-09-23T20:08:22Z

@tecimovic deleted and git-ignoring the transpiled file.

paulr34 · 2025-09-26T20:09:16Z

@dhchandw it says "fix download artifact script" but the script is deleted in your PR

paulr34 · 2025-09-26T20:10:41Z

I see there are two of the same script?

dhchandw · 2025-10-23T19:34:52Z

I see there are two of the same script?

@paulr34 The typescript file is the script that my PR is talking about, the javascript file you see is just the transpiled file.

brdandu · 2025-10-24T18:16:48Z

package.json

  "scripts": {
    "download-artifact": "npx ts-node src-script/download-artifact.ts",
-    "pkg:download-artifact": "npx pkg src-script/download-artifact.js  -t node18-linux-x64,node18-linux-arm64,node18-macos-x64,node18-win-x64 --output dist/download-artifact --compress GZip",
+    "pkg:download-artifact": "npx pkg src-script/download-artifact.js  -t node16-linux-x64,node16-linux-arm64,node16-macos-x64,node16-win-x64 --output dist/download-artifact --compress GZip",


Why is the node versions being downgraded? we should be upgrading if anything.

Packaging with node18 is slowing down the performance for this particular artifact, maybe because of the packages used. We are phasing this out so didn't bother to dig deeper into this.

Not really sue what slowing down performance means here. Educate me later on this.

Give Node 20 a try too here

brdandu · 2025-10-24T18:17:14Z

.gitignore

 .clinic

+# Compiled JavaScript output from TypeScript source
+src-script/download-artifact.js


Does this exist?

It will if somebody compiles the type script code, we don't want them to commit that.

brdandu · 2025-10-24T18:17:50Z

src-script/download-artifact.ts

      owner,
-      repo
+      repo,
+      headers: { authorization: `token ${githubToken}` }


Why was this change needed?

This sends the Github token as the Github API expects it

Did the api change with no backwards compatibility?

brdandu · 2025-10-24T18:18:50Z

src-script/download-artifact.ts

+    const headers = options.githubToken
+      ? { Authorization: `token ${options.githubToken}` }
+      : undefined
+    let resp = await axios.get(url, { headers })


Why is this change needed?

This sends the Github token for the API if available, this call is made even if the Github token is not passed in (downloading from Artifactory)

ethanzhouyc · 2025-10-30T14:28:47Z

package.json

  "scripts": {
    "download-artifact": "npx ts-node src-script/download-artifact.ts",
-    "pkg:download-artifact": "npx pkg src-script/download-artifact.js  -t node18-linux-x64,node18-linux-arm64,node18-macos-x64,node18-win-x64 --output dist/download-artifact --compress GZip",
+    "pkg:download-artifact": "npx pkg src-script/download-artifact.js  -t node16-linux-x64,node16-linux-arm64,node16-macos-x64,node16-win-x64 --output dist/download-artifact --compress GZip",


Give Node 20 a try too here

- package download-artifact using node 16 (better performance) - add brief comments to download-artifact.ts to satisy linting rules

dhchandw requested review from brdandu, paulr34 and tecimovic as code owners September 16, 2025 23:01

gemini-code-assist bot reviewed Sep 16, 2025

View reviewed changes

src-script/download-artifact.ts Show resolved Hide resolved

dhchandw requested a review from ethanzhouyc September 17, 2025 17:58

tecimovic reviewed Sep 19, 2025

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

dhchandw force-pushed the bug/fixDownloadArtifact branch 2 times, most recently from 47cbbe0 to 4d1cb78 Compare September 23, 2025 20:06

dhchandw requested a review from tecimovic September 23, 2025 20:06

dhchandw force-pushed the bug/fixDownloadArtifact branch from 4d1cb78 to c08d53a Compare October 23, 2025 19:32

dhchandw force-pushed the bug/fixDownloadArtifact branch from c08d53a to e970564 Compare October 23, 2025 19:35

brdandu requested changes Oct 24, 2025

View reviewed changes

dhchandw requested a review from brdandu October 29, 2025 18:29

brdandu approved these changes Oct 29, 2025

View reviewed changes

ethanzhouyc approved these changes Oct 30, 2025

View reviewed changes

Fix download-artifact script - use github token for all Github API calls

a952afd

- package download-artifact using node 16 (better performance) - add brief comments to download-artifact.ts to satisy linting rules

dhchandw force-pushed the bug/fixDownloadArtifact branch from e970564 to a952afd Compare October 30, 2025 18:24

dhchandw merged commit f48427d into project-chip:master Oct 30, 2025
14 checks passed

dhchandw deleted the bug/fixDownloadArtifact branch October 30, 2025 19:09

fix download-artifact script #1647

fix download-artifact script #1647

Uh oh!

Conversation

dhchandw commented Sep 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

tecimovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dhchandw commented Sep 23, 2025

Uh oh!

paulr34 commented Sep 26, 2025

Uh oh!

paulr34 commented Sep 26, 2025

Uh oh!

dhchandw commented Oct 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhchandw Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dhchandw Oct 29, 2025 •

edited

Loading