Skip to content

Conversation

akashveramd
Copy link

Some ROCm runners do not have AWS CLI installed. Hence, in PyTorch we rely on github aws-actions instead of the CLI for authentication. To provide support for workflow files using linux_job_v2.yml, added aws-actions authentication to linux_job_v2.yml only for ROCm arch.

It is needed to get torchtitan PR going pytorch/torchtitan#1786. It currently faces issue with https://github.com/pytorch/torchtitan/actions/runs/18294860941/job/52090769397?pr=1786

Copy link

vercel bot commented Oct 7, 2025

@akashveramd is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2025
@akashveramd
Copy link
Author

@huydhn @malfet: Can I please get a review for this PR?

Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Updated (UTC)
torchci Ignored Ignored Preview Oct 9, 2025 8:56am

@huydhn
Copy link
Contributor

huydhn commented Oct 9, 2025

I doubt that this works though as I'm pretty sure that when ROCm tries to use this. The workflow will complain about missing id-token: write, so I have create a non-fork test PR here #7329. We can test it out in pytorch/torchtitan#1786

@akashveramd
Copy link
Author

Closing in favor of PR #7329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants