Skip to content

Added aws authentication to linux_job_v2.yml only for rocm. #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Added aws authentication to linux_job_v2.yml only for rocm. #7329

wants to merge 3 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 9, 2025 •
edited
Loading

Redo #7311 but on a non-fork PR for testing

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Updated (UTC)
torchci Ignored Ignored Preview Oct 10, 2025 5:41am

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
This was referenced Oct 9, 2025
Closed
Open
@jithunnair-amd
Copy link
Contributor

jithunnair-amd commented Oct 9, 2025 •
edited
Loading

@huydhn This should also work to conditionally run the AWS credential steps only for ROCm, but I think a better solution exists in pytorch/pytorch#164769, and has been tested through all the PyTorch workflows already. It's better because it moves the steps into setup-rocm, which needs to be called by any jobs that want to run on ROCm runners. And setup-rocm is already being called conditionally for ROCm in linux_job_v2.yml:

test-infra/.github/workflows/linux_job_v2.yml

Line 168 in 823b7f9

uses: pytorch/pytorch/.github/actions/setup-rocm@main

@akashveramd akashveramd mentioned this pull request Oct 10, 2025
Closed
huydhn
huydhn commented Oct 10, 2025
View reviewed changes
@huydhn
Revert "Install awscli"
b2bce23 
This reverts commit 4c1baf1.
@huydhn huydhn requested a review from atalman October 10, 2025 05:59
@huydhn huydhn marked this pull request as ready for review October 10, 2025 05:59
@jithunnair-amd
Copy link
Contributor

Since we merged pytorch/pytorch#164769, I think this one is probably unnecessary, since the same steps are being done in setup-rocm.yml now after that PR.

@jithunnair-amd jithunnair-amd marked this pull request as draft October 10, 2025 22:01
@huydhn huydhn closed this Oct 11, 2025
@huydhn huydhn deleted the 7311 branch October 16, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huydhn @jithunnair-amd @akashveramd