Skip to content

Revert "Revert "Add diagnostics (#1015) #abi-breaking" #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: humble
Choose a base branch
from
Open

Revert "Revert "Add diagnostics (#1015) #abi-breaking" #2137

wants to merge 6 commits into from
+47 −3

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Mar 26, 2025

First attempt at #2104

Raivias
Raivias approved these changes Jul 1, 2025
View reviewed changes
Copy link

@Raivias Raivias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there's some concern on the related issue about this breaking ABI. I'm going to approve the PR with the assumption that the conversation on the issue page gets resolved before this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raivias Raivias Raivias approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@christophfroehlich christophfroehlich Awaiting requested review from christophfroehlich

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@livanov93 livanov93 Awaiting requested review from livanov93

@mamueluth mamueluth Awaiting requested review from mamueluth

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmagyar @Raivias