Skip to content

Conversation

sayan-biswas
Copy link
Contributor

@sayan-biswas sayan-biswas commented Aug 29, 2025

Changes

  • Check if BuildSpec exists in Status of BuildRun, since it an optional field in the API
  • Try to get SourceOrigin from BuildRunSpec if it doesn't exist in BuildRun status.

Fixes #339

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fixes "buildrun list" command for BuildRuns with invalid BuildSpec.

# Changes:
- Check if BuildSpec exists in Status of BuildRun, since it an optional field in the API
- Try to get SourceOrigin from BuildRunSpec if it doesn't exist in BuildRun status.

Signed-off-by: Sayan Biswas <[email protected]>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2025
@openshift-ci openshift-ci bot requested review from adambkaplan and rxinui August 29, 2025 10:58
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[BUG] panic: runtime error: invalid memory address or nil pointer dereference, when listing BuildRun
1 participant