Skip to content

Fix buildrun list command #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Fix buildrun list command #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions pkg/shp/cmd/buildrun/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,26 @@ func (c *ListCommand) Run(params *params.Params, io *genericclioptions.IOStreams
for _, br := range brs.Items {
name := br.Name
buildName := br.Spec.BuildName()
outputImage := br.Status.BuildSpec.Output.Image
sourceOrigin := br.Status.BuildSpec.Source.Type
outputImage := "-"
source := "-"
if sourceOrigin == "Git" {
source = br.Status.BuildSpec.Source.Git.URL
revision := br.Status.BuildSpec.Source.Git.Revision
if revision != nil {
source += "@" + *revision
sourceOrigin := "-"
// Check if BuildSpec is present in Status as this is an optional pointer field.
if br.Status.BuildSpec != nil {
outputImage = br.Status.BuildSpec.Output.Image

// In case the Source is not preset in the BuildSpec, try to get it from BuildRun spec.
if br.Status.BuildSpec.Source != nil {
sourceOrigin = string(br.Status.BuildSpec.Source.Type)
} else if br.Spec.Source != nil {
sourceOrigin = string(br.Spec.Source.Type)
}

if sourceOrigin == "Git" {
source = br.Status.BuildSpec.Source.Git.URL
revision := br.Status.BuildSpec.Source.Git.Revision
if revision != nil {
source += "@" + *revision
}
}
}

Expand Down