Fix Pressable's onPress being called on cancellation
#3678
Merged
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @latekvo , Thanks for the PR! Any plans to get this merged? This seems to be a major issue on iOS as mentioned on the comment linked above. I've also applied these changes via a patch file, and all seems to be good for now. My issue: For me, the issue is when a Pressable component is either in a FlatList or a FlashList. The Pressable component just instantly triggers as soon as I touch the screen to scroll (both on simulator and on a physical device; new arch; iOS-only). It works just fine on Android. Happening since 2.27.0, not before that. |
…e-activation-on-cancellation
|
@AfrazHussain we'll include this fix in the next release. Apologies for the delay. |
latekvo
deleted the
@latekvo/fix-pressable-activation-on-cancellation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
Pressable'sonPresscallback being called despite the press being cancelled.Credit for finding and fixing this issue goes to @gigobyte.
Fixes #3609
Test plan
Pressableto the right.onPresscallback would be called without the finger being lifted.onPressis no longer called when the finger isn't lifted.