Skip to content

Fix Pressable's onPress being called on cancellation #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2025
Merged

Fix Pressable's onPress being called on cancellation #3678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3b19ea
check for success in onFinalize
latekvo Aug 20, 2025
e01edaa
add cancellation event, use mock event data
latekvo Aug 28, 2025
37bd9f6
remove log
latekvo Aug 28, 2025
97ca0fb
Merge remote-tracking branch 'origin/main' into @latekvo/fix-pressabl…
latekvo Sep 9, 2025
d645840
remove unused code
latekvo Sep 9, 2025
4ad0d74
revert unrelated change
latekvo Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/react-native-gesture-handler/src/components/Pressable/Pressable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,13 @@ const Pressable = (props: PressableProps) => {
stateMachine.reset();
handlePressOut(pressableEvent, false);
})
.onFinalize(() => {
.onFinalize((_event, success) => {
if (Platform.OS === 'web') {
stateMachine.handleEvent(StateMachineEvent.FINALIZE);
if (success) {
stateMachine.handleEvent(StateMachineEvent.FINALIZE);
} else {
stateMachine.handleEvent(StateMachineEvent.CANCEL);
}
handleFinalize();
}
}),
Expand Down Expand Up @@ -301,11 +305,15 @@ const Pressable = (props: PressableProps) => {
stateMachine.handleEvent(StateMachineEvent.NATIVE_START);
}
})
.onFinalize(() => {
.onFinalize((_event, success) => {
if (Platform.OS !== 'web') {
// On Web we use LongPress().onFinalize() instead of Native().onFinalize(),
// as Native cancels on mouse move, and LongPress does not.
stateMachine.handleEvent(StateMachineEvent.FINALIZE);
if (success) {
stateMachine.handleEvent(StateMachineEvent.FINALIZE);
} else {
stateMachine.handleEvent(StateMachineEvent.CANCEL);
}
handleFinalize();
}
}),
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-gesture-handler/src/components/Pressable/stateDefinitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export enum StateMachineEvent {
NATIVE_START = 'nativeStart',
FINALIZE = 'finalize',
LONG_PRESS_TOUCHES_DOWN = 'longPressTouchesDown',
CANCEL = 'cancel',
}

function getAndroidStatesConfig(
Expand Down
Loading