Chore/remove affirmation map from chainscoordinator #6332

jferrant · 2025-07-24T16:47:43Z

Fully closes #6314

This is nice to see:

Signed-off-by: Jacinta Ferrant <[email protected]>

…irmation_maps_at_height, and find_valid_sortitions Signed-off-by: Jacinta Ferrant <[email protected]>

…ain_block Signed-off-by: Jacinta Ferrant <[email protected]>

Signed-off-by: Jacinta Ferrant <[email protected]>

…k_compatible_with_affirmation_map Signed-off-by: Jacinta Ferrant <[email protected]>

stackslib/src/chainstate/coordinator/mod.rs

stackslib/src/net/api/getinfo.rs

Signed-off-by: Jacinta Ferrant <[email protected]>

… into chore/remove-affirmation-map-from-chainscoordinator

stackslib/src/net/tests/inv/epoch2x.rs

Signed-off-by: Jacinta Ferrant <[email protected]>

…dless of epoch Signed-off-by: Jacinta Ferrant <[email protected]>

Signed-off-by: Jacinta Ferrant <[email protected]>

…nchor_v205 Signed-off-by: Jacinta Ferrant <[email protected]>

…it_affirmation Signed-off-by: Jacinta Ferrant <[email protected]>

…cle as the sync start point, and remove a now-defunct test (PoX bitvectors are always 1's, so there is no need to test for the case when there's a 0)

chore: fix epoch2x inv sync

Signed-off-by: Jacinta Ferrant <[email protected]>

… into chore/remove-affirmation-map-from-chainscoordinator

stackslib/src/chainstate/stacks/db/headers.rs

kantai

This looks good to me -- just have a comment about dropping the affirmation weight column.

Signed-off-by: Jacinta Ferrant <[email protected]>

…rmation_maps from burnchain db Signed-off-by: Jacinta Ferrant <[email protected]>

…and update changelog Signed-off-by: Jacinta Ferrant <[email protected]>

Signed-off-by: Jacinta Ferrant <[email protected]>

jcnelson · 2025-09-04T01:06:18Z

stacks-node/src/tests/epoch_21.rs

@@ -2894,7 +2885,6 @@ fn test_pox_reorg_one_flap() {

 /// PoX reorg tests where two miners take turn mining hidden anchor blocks.
 /// Both miners mine in the reward phase, and in doing so, confirm their hidden anchor blocks.
-/// The heaviest affirmation map grows as n+pppa+


I'm not even sure this test could pass anymore. This test exercises the affirmation map system.

Removed in a9aa74e

jcnelson · 2025-09-04T01:07:24Z

stacks-node/src/tests/epoch_21.rs

@@ -2289,8 +2289,6 @@ fn test_pox_reorgs_three_flaps() {
    for (i, c) in confs.iter().enumerate() {
        let tip_info = get_chain_info(c);
        info!("Tip for miner {i}: {tip_info:?}");
-


This tests the affirmation map system, so it's not expected to pass with its removal.

Will take a look. If you think it should just be removed, can do.

Removed in a9aa74e

jcnelson · 2025-09-04T01:08:06Z

stackslib/src/burnchains/affirmation.rs

-    );
-
-    Ok(())
-}


wooo! bye-bye 1K-line file 😁

jcnelson · 2025-09-04T01:16:56Z

This all looks great to me! Just waiting for this to be a non-draft and for CI to pass.

…evant Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant · 2025-09-04T15:54:50Z

This all looks great to me! Just waiting for this to be a non-draft and for CI to pass.

I removed 5 tests in tests::epoch_21 and 1 from tests::epoch_22

… into chore/remove-affirmation-map-from-chainscoordinator

…olumn and add tests Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant added 8 commits July 23, 2025 14:41

Remove handle_affirmation_reorg, check_pox_anchor_affirmation

ba1ceac

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove check_chainstate_against_burnchain_affirmations

c695609

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove undo_stacks_block_orphaning

da251cf

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove affirmation_maps_active

fac38a7

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove find_invalid_and_revalidated_sortitions, get_snapshots_and_aff…

4c7abfc

…irmation_maps_at_height, and find_valid_sortitions Signed-off-by: Jacinta Ferrant <[email protected]>

Remove check for compatible_stacks_blocks in handle_new_epoch2_burnch…

32aa1a6

…ain_block Signed-off-by: Jacinta Ferrant <[email protected]>

Remove find_highest_stacks_block_with_compatible_affirmation_map

2d57bce

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove consolidate_affirmation_maps, *_get_*_affirmation_map, is_bloc…

4f43f7f

…k_compatible_with_affirmation_map Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant requested review from a team as code owners July 24, 2025 16:47

jferrant added this to Stacks Core Eng Jul 24, 2025

jferrant moved this to Status: In Review in Stacks Core Eng Jul 24, 2025

jferrant added this to the 3.2.0.0.1 milestone Jul 24, 2025

jferrant self-assigned this Jul 24, 2025

jcnelson reviewed Jul 24, 2025

View reviewed changes

stackslib/src/chainstate/coordinator/mod.rs Outdated Show resolved Hide resolved

jcnelson reviewed Jul 24, 2025

View reviewed changes

stackslib/src/net/api/getinfo.rs Outdated Show resolved Hide resolved

jferrant added 3 commits July 24, 2025 12:00

Fix failing test_inv_sync_start_reward_cycle

d1fdb69

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove AffirmationMaps from getinfo endpoint

36c427b

Signed-off-by: Jacinta Ferrant <[email protected]>

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

ff7b3b4

… into chore/remove-affirmation-map-from-chainscoordinator

wileyj moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 25, 2025

jferrant commented Jul 25, 2025

View reviewed changes

stackslib/src/net/tests/inv/epoch2x.rs Show resolved Hide resolved

jferrant added 9 commits July 28, 2025 11:12

Remove require_affirmed_anchor_blocks config options

70b773a

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove always_use_affirmation_maps config option

86d281c

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove assume_present_anchor_blocks config option

e40e0cf

Signed-off-by: Jacinta Ferrant <[email protected]>

check_missing_anchor_block should stall if missing anchor block regar…

b72a6ab

…dless of epoch Signed-off-by: Jacinta Ferrant <[email protected]>

Fix test_pox_no_anchor_selected

6c36933

Signed-off-by: Jacinta Ferrant <[email protected]>

Fix test_pox_no_anchor_selected

ea15d55

Signed-off-by: Jacinta Ferrant <[email protected]>

Fix test_simple_setup

33fbe18

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove affirmation_overrides config

cd1b4cc

Signed-off-by: Jacinta Ferrant <[email protected]>

Fix test_generate_markdown_with_real_fixture_data

b74cf10

Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant and others added 6 commits August 25, 2025 13:02

CRC: should include prior reward cycle for get_block_scan_start

5ed4860

Signed-off-by: Jacinta Ferrant <[email protected]>

WIP: remove process_affirmation_maps and always call get_chosen_pox_a…

ae41678

…nchor_v205 Signed-off-by: Jacinta Ferrant <[email protected]>

WIP: remove insert_block_commit_affirmation_map and update_block_comm…

8d22715

…it_affirmation Signed-off-by: Jacinta Ferrant <[email protected]>

chore: fix epoch2x inv sync to use a given node's last-seen reward cy…

782e167

…cle as the sync start point, and remove a now-defunct test (PoX bitvectors are always 1's, so there is no need to test for the case when there's a 0)

Merge pull request #2 from jcnelson/fix/fix-epoch2x-inv-sync

e5f5413

chore: fix epoch2x inv sync

Cleanup

f0af8d4

Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant requested review from hstove and obycode and removed request for hstove August 27, 2025 22:50

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

6bc5d43

… into chore/remove-affirmation-map-from-chainscoordinator

aldur requested a review from rdeioris September 2, 2025 14:40

kantai reviewed Sep 3, 2025

View reviewed changes

stackslib/src/chainstate/stacks/db/headers.rs Outdated Show resolved Hide resolved

kantai reviewed Sep 3, 2025

View reviewed changes

jferrant marked this pull request as draft September 3, 2025 19:44

jferrant added 4 commits September 3, 2025 13:37

Remove affirmation_weight from block_headers in chainstate db

bb4423a

Signed-off-by: Jacinta Ferrant <[email protected]>

Remove affirmation_id from block_commit_metadata and drop it and affi…

166234d

…rmation_maps from burnchain db Signed-off-by: Jacinta Ferrant <[email protected]>

Remove remaining references to affirmation maps throughout code base …

838d309

…and update changelog Signed-off-by: Jacinta Ferrant <[email protected]>

Fix supports_epoch

82d87e9

Signed-off-by: Jacinta Ferrant <[email protected]>

jcnelson reviewed Sep 4, 2025

View reviewed changes

stackslib/src/burnchains/affirmation.rs

);

Ok(())

}

Copy link

Member

jcnelson Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo! bye-bye 1K-line file 😁

jferrant reacted with thumbs up emoji

Remove pox flapping/missing anchor block tests that no longer are rel…

a9aa74e

…evant Signed-off-by: Jacinta Ferrant <[email protected]>

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

c028f83

… into chore/remove-affirmation-map-from-chainscoordinator

jferrant requested review from jcnelson and kantai September 4, 2025 18:04

jferrant marked this pull request as ready for review September 4, 2025 18:04

jferrant requested a review from a team as a code owner September 4, 2025 18:04

CRC: clean up CHAINSTATE_SCHEMA_5 to simply drop affirmation_weight c…

7cfff95

…olumn and add tests Signed-off-by: Jacinta Ferrant <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Chore/remove affirmation map from chainscoordinator #6332

Chore/remove affirmation map from chainscoordinator #6332

jferrant commented Jul 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kantai left a comment

Uh oh!

jcnelson Sep 4, 2025

Uh oh!

jferrant Sep 4, 2025

Uh oh!

jcnelson Sep 4, 2025

Uh oh!

jferrant Sep 4, 2025 •

edited

Loading

Uh oh!

jferrant Sep 4, 2025

Uh oh!

jcnelson Sep 4, 2025

Uh oh!

jcnelson commented Sep 4, 2025

Uh oh!

jferrant commented Sep 4, 2025

Uh oh!

Uh oh!

-                  );
-                  Ok(())
-              }

Chore/remove affirmation map from chainscoordinator #6332

Are you sure you want to change the base?

Chore/remove affirmation map from chainscoordinator #6332

Conversation

jferrant commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kantai left a comment

Choose a reason for hiding this comment

Uh oh!

jcnelson Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jferrant Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jcnelson Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jferrant Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jferrant Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jcnelson Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jcnelson commented Sep 4, 2025

Uh oh!

jferrant commented Sep 4, 2025

Uh oh!

Uh oh!

jferrant commented Jul 24, 2025 •

edited

Loading

jferrant Sep 4, 2025 •

edited

Loading