Chore/remove affirmation map from chainscoordinator

.github/workflows/bitcoin-tests.yml

@@ -80,11 +80,6 @@ jobs:
           - test-name: tests::epoch_205::test_dynamic_db_method_costs
           - test-name: tests::epoch_205::test_exact_block_costs
           - test-name: tests::epoch_205::transition_empty_blocks
-          - test-name: tests::epoch_21::test_pox_missing_five_anchor_blocks
-          - test-name: tests::epoch_21::test_pox_reorg_flap_duel
-          - test-name: tests::epoch_21::test_pox_reorg_flap_reward_cycles
-          - test-name: tests::epoch_21::test_pox_reorg_one_flap
-          - test-name: tests::epoch_21::test_pox_reorgs_three_flaps
           - test-name: tests::epoch_21::test_sortition_divergence_pre_21
           - test-name: tests::epoch_21::test_v1_unlock_height_with_current_stackers
           - test-name: tests::epoch_21::test_v1_unlock_height_with_delay_and_current_stackers
@@ -99,7 +94,6 @@ jobs:
           - test-name: tests::epoch_21::transition_removes_pox_sunset
           - test-name: tests::epoch_22::disable_pox
           - test-name: tests::epoch_22::pox_2_unlock_all
-          - test-name: tests::epoch_22::test_pox_reorg_one_flap
           - test-name: tests::epoch_23::trait_invocation_behavior
           - test-name: tests::epoch_24::fix_to_pox_contract
           - test-name: tests::epoch_24::verify_auto_unlock_behavior

CHANGELOG.md

@@ -16,7 +16,7 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE
 
 - Clarity errors pertaining to syntax binding errors have been made more
   expressive (#6337)
-
+- Removed affirmation maps logic throughout, upgrading chainstate DB schema to 11 and burnchain DB schema to 3 (#6314)
 
 ## [3.2.0.0.1]
 

contrib/tools/config-docs-generator/tests/fixtures/minimal_config.json

@@ -48,7 +48,7 @@
                 },
                 {
                     "name": "miner",
-                    "description": "Flag indicating whether this node should activate its mining logic and attempt to\nproduce Stacks blocks. Setting this to `true` typically requires providing\nnecessary private keys (either [`NodeConfig::seed`] or [`MinerConfig::mining_key`]).\nIt also influences default behavior for settings like\n[`NodeConfig::require_affirmed_anchor_blocks`].",
+                    "description": "Flag indicating whether this node should activate its mining logic and attempt to\nproduce Stacks blocks. Setting this to `true` typically requires providing\nnecessary private keys (either [`NodeConfig::seed`] or [`MinerConfig::mining_key`]).",
                     "default_value": "`false`",
                     "notes": null,
                     "deprecated": null,
@@ -74,7 +74,6 @@
     "referenced_constants": {
         "MinerConfig::mining_key": null,
         "NodeConfig::miner": null,
-        "NodeConfig::mine_microblocks": null,
-        "NodeConfig::require_affirmed_anchor_blocks": null
+        "NodeConfig::mine_microblocks": null
     }
 }

docs/rpc/components/examples/node-info.example.json

@@ -17,12 +17,6 @@
   "is_fully_synced": false,
   "node_public_key": "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01",
   "node_public_key_hash": "1328af7c4f96eee8fdbb1e023e48ba11e255d1c8",
-  "affirmations": {
-    "heaviest": "",
-    "stacks_tip": "",
-    "sortition_tip": "",
-    "tentative_best": ""
-  },
   "last_pox_anchor": {
     "anchor_block_hash": "47c20352492e1647127d6f6275fa5abfe90157f6a64e6a175ff45ed0c1fb3f4e",
     "anchor_block_txid": "5b5d678c658525122fa73a8699b5810325ce9412bf0dc3762fb7518699be3d4d"

docs/rpc/components/schemas/node-info.schema.yaml

@@ -88,21 +88,6 @@ properties:
   node_public_key_hash:
     type: [string, "null"]
     description: The HASH160 of the node's public key.
-  affirmations:
-    type: [object, "null"]
-    properties:
-      heaviest:
-        type: string
-        description: Encoded affirmation map string.
-      stacks_tip:
-        type: string
-        description: Encoded affirmation map string.
-      sortition_tip:
-        type: string
-        description: Encoded affirmation map string.
-      tentative_best:
-        type: string
-        description: Encoded affirmation map string.
   last_pox_anchor:
     type: [object, "null"]
     properties:

stacks-node/src/main.rs

@@ -139,7 +139,6 @@ fn cli_get_miner_spend(
         &mut sortdb,
         &burnchain,
         &OnChainRewardSetProvider(no_dispatcher),
-        config.node.always_use_affirmation_maps,
     )
     .unwrap();
 

stacks-node/src/neon_node.rs

@@ -2109,7 +2109,6 @@ impl BlockMinerThread {
             burn_db,
             &self.burnchain,
             &OnChainRewardSetProvider::new(),
-            self.config.node.always_use_affirmation_maps,
         ) {
             Ok(x) => x,
             Err(e) => {

stacks-node/src/node.rs

@@ -840,22 +840,13 @@ impl Node {
             parent_consensus_hash
         };
 
-        let burnchain = self.config.get_burnchain();
-        let burnchain_db =
-            BurnchainDB::connect(&burnchain.get_burnchaindb_path(), &burnchain, true)
-                .expect("FATAL: failed to connect to burnchain DB");
-
         let atlas_config = Self::make_atlas_config();
         let mut processed_blocks = vec![];
         loop {
             let mut process_blocks_at_tip = {
                 let tx = db.tx_begin_at_tip();
-                self.chain_state.process_blocks(
-                    burnchain_db.conn(),
-                    tx,
-                    1,
-                    Some(&self.event_dispatcher),
-                )
+                self.chain_state
+                    .process_blocks(tx, 1, Some(&self.event_dispatcher))
             };
             match process_blocks_at_tip {
                 Err(e) => panic!("Error while processing block - {e:?}"),

stacks-node/src/run_loop/nakamoto.rs

@@ -323,11 +323,6 @@ impl RunLoop {
                 let mut fee_estimator = moved_config.make_fee_estimator();
 
                 let coord_config = ChainsCoordinatorConfig {
-                    assume_present_anchor_blocks: moved_config.node.assume_present_anchor_blocks,
-                    always_use_affirmation_maps: moved_config.node.always_use_affirmation_maps,
-                    require_affirmed_anchor_blocks: moved_config
-                        .node
-                        .require_affirmed_anchor_blocks,
                     txindex: moved_config.node.txindex,
                 };
                 ChainsCoordinator::run(