Sub-component support #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codders
reviewed
Jun 12, 2025
| if ( str_starts_with( $error->message, 'Tag template invalid' ) ) { | ||
| $msg = $error->message; | ||
| if ( str_starts_with( $msg, 'Tag ' ) && str_ends_with( $msg, " invalid\n" ) ) { | ||
| // discard "Tag xyz invalid" messages from libxml2 < 2.14.0(?) |
There was a problem hiding this comment.
Yeah, it’s annoying that it doesn’t happen for me locally, only in CI :S
|
This looks good to me. It's unfortunate that we need the error workaround for libxml, but that seems like it might be unavoidable. |
The App class lets us reuse the same HtmlParser and JsExpressionParser across multiple components (note that JsExpressionParser returns an unevaluated expression, so it’s fine to cache its results even if they’re going to be evaluated with different data later), and also keeps a library of components. The components are loaded and compiled on-demand the first time they’re used, and reused afterwards; for this, Component now clones its root node before operating on it. For Component to work correctly, it’s important that the cloned node still has a parent node (otherwise it’s considered to have been removed from the DOM, and most of the processing for it is skipped); use a cloneOwner node for that purpose. (For now, it’s just the document’s document element, i.e. the <html>, but we could make it a separate node later if we prefer. It just has to be outside the root node.) (If you’re wondering, my motivation for making the components input either string or callable is that it probably makes sense not to load all the component files into strings upfront, but to only do that if the component is needed.)
This is a bit odd in that Component doesn’t even know which components are registered in the app; sub-component handling is triggered iff the tag name contains a hyphen. I think this is reasonable, but we might still end up changing it. Note that the sub-component must be a descendent of the template root note; a template cannot just consist of a call to a sub-component. (If it does, Component::render() crashes when trying to remove the $rootNode from the cloneOwner because it’s already been replaced in handleComponent().)
codders
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages. Support for callable components is not included, since that needs more work (see the
app+callablebranch).