Make the UserAgent class a Singleton #21794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21794-33637e5 | |
| Commit | 33637e5 | |
| Direct Download | jetpack-prototype-build-pr21794-33637e5.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21794-33637e5 | |
| Commit | 33637e5 | |
| Direct Download | wordpress-prototype-build-pr21794-33637e5.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21794 +/- ##
=======================================
Coverage 39.32% 39.32%
=======================================
Files 2125 2125
Lines 99871 99871
Branches 15385 15385
=======================================
Hits 39277 39277
Misses 57114 57114
Partials 3480 3480 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
dcalhoun
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR changes the
UserAgentclass to a singleton and uses a privatesetterfor the user agent string. This was initially done as part of #21681, which retrieved the default user agent in the background, but after discussion it was decided this could cause more problems than it solves.Note the reason for the previous PR was there is some overhead to calling
WebSettings.getDefaultUserAgent()because as described here, the first time that's called requires loadingWebViewcode. This PR doesn't address that overhead, but making the class a singleton gets us a step closer.Also note avoiding calling
WebSettings.getDefaultUserAgent()at startup so the delay isn't so noticeable isn't a solution since we set the user agent for ourRestClientUtilshere.I'm not sure of testing steps, other than to verify that the correct user agent is being returned.