Skip to content

Make the UserAgent class a Singleton #21794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged

Make the UserAgent class a Singleton #21794

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a94b8c0
Make the UserAgent class a Singleton
nbradbury Apr 9, 2025
8c801f7
Use a private setter
nbradbury Apr 10, 2025
d0345e5
Merge branch 'trunk' into issue/user-agent-singleton
nbradbury Apr 10, 2025
33637e5
Merge branch 'trunk' into issue/user-agent-singleton
nbradbury Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libs/fluxc/src/main/java/org/wordpress/android/fluxc/network/UserAgent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@ package org.wordpress.android.fluxc.network
import android.content.Context
import android.webkit.WebSettings
import org.wordpress.android.util.PackageUtils
import javax.inject.Singleton

@Singleton
@SuppressWarnings("SwallowedException", "TooGenericExceptionCaught", "MemberNameEqualsClassName")
class UserAgent(appContext: Context?, appName: String) {
val userAgent: String
var userAgent: String
private set

init {
// Device's default User-Agent string.
Expand Down