Update Mecanum Drive constructor to match other constructors #8187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artifacts weren't in OS and architecture subfolders in the zip like all the other C++ tools
The UKF test was calling `.value()` on an implicit `units::millisecond_t` type assuming it was `units::second_t`. I normalized the rest of the dt declarations while I was at it.
…r Mecanum Drive constructors for Wheel Speeds and Wheel Positions.
github-actions
bot
added
component: wpilibj
|
I've retargeted this PR to the 2027 branch since we don't want to make a breaking change like this for 2026. You'll need to rebase your branch though to fix the conflicts. |
In the recent gradle or gradle dependencies update, the documentation zips were being published as documentation-version-unspecified, where the unspecified was coming from archiveVersion. It looks like we use a different method of setting the version, so make sure that archiveVersion is empty
…libsuite#7996) Co-authored-by: Sam Carlberg <[email protected]>
sccache was enabled but didn't have write credentials
Signed-off-by: Jade Turner <[email protected]>
github-actions
bot
added
component: wpiutil
|
You'll need to rebase this branch onto the 2027 branch. |
|
Apologies, didn't mean to do that, was trying to figure out rebranch on my end, and must have accidentally clicked something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Mecanum Drive constructor to match parameter structure of other Mecanum Drive constructors for Wheel Speeds and Wheel Positions. Fixes #7493