Improve dbal config

[rustamwin]

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	✔️

Before:

definition

[
    //...
    SimplePsrLogger::class => getPsrLogger()
];

params

'dbal' => [
        // SQL query logger. Definition of Psr\Log\LoggerInterface
        'query-logger' => SimplePsrLogger::class,
        // Default database
        'default' => null,
        'aliases' => [],
        'databases' => [],
        'connections' => [],
],

After:

definition

[
//...
DatabaseManager::class => static function (DbalFactory $dbalFactory) use (&$params) {
        $config = $params['yiisoft/yii-cycle']['dbal'];

        return $dbalFactory->create($config);
    },
//...
];

params

'dbal' => [
        // Whether to enable logging of all SQL queries to PSR logger.
        'query-logging' => false,
        // Default database
        'default' => null,
        'aliases' => [],
        'databases' => [],
        'connections' => [],
],

Using any PSR logger:

[
//...
DatabaseManager::class => static function () use (&$params) {
        $config = $params['yiisoft/yii-cycle']['dbal'];
        $logger = new MyPsrLogger();
        $dbalFactory = new DbalFactory($logger)
        return $dbalFactory->create($config);
    },
//...
];

[samdark]

Looks good. Is it possible to avoid BC break?

[rustamwin]

Is it possible to avoid BC break?

It's OK, since there are already changes in the changelog that breaks BC.

[vjik]

Issue is opened yet.

[rustamwin]

But it works, see tests.

[vjik]

But it works, see tests.

Which test checks driver logger?

[rustamwin]

https://github.com/yiisoft/yii-cycle/pull/228/files#diff-d57502caa1cc57889c1bfb212365a384a5b47481f46ce952f3a4014fe9228264

[roxblnfk]

Could you provide an example of the configuration before and after in the PR description? It seems that previously you could specify any PSR logger for database queries, but now it's a boolean value that turns the default logger on or off.

[rustamwin]

Could you provide an example of the configuration before and after in the PR description? It seems that previously you could specify any PSR logger for database queries, but now it's a boolean value that turns the default logger on or off.

Done.

[roxblnfk]

The logs configuration behavior looks breaking changed there.
I can't say that I like the new behavior but I think it's 2.0