[20/n] tensor engine, more refactoring of dependent error handling #620
+210
−525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a SeqError type which represents the 'root' seq that failed, clearly delinated from dependent errors in the type system. env objects are now changed to hold Arc<SeqError> with the lookup functions always returning a DependentError of the seq error. This makes it clear that our error type does not nest dependent errors, and it makes it clear where function invocation errors first get introduced. I use this to introduce a single place that creates the Arc<SeqError>, reports the error to the controller, and sets it as the last error so that recordings know that error occurred. This PR also removes partially finished work to propagate pipe creation errors to users of the pipe. We will not need pipes for much longer, and this functionality wasn't complete anyway. Differential Revision: [D78683472](https://our.internmc.facebook.com/intern/diff/D78683472/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78683472/)! [ghstack-poisoned]
This was referenced Jul 22, 2025
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78683472 |
This was referenced Jul 22, 2025
…handling" This PR introduces a SeqError type which represents the 'root' seq that failed, clearly delinated from dependent errors in the type system. env objects are now changed to hold Arc<SeqError> with the lookup functions always returning a DependentError of the seq error. This makes it clear that our error type does not nest dependent errors, and it makes it clear where function invocation errors first get introduced. I use this to introduce a single place that creates the Arc<SeqError>, reports the error to the controller, and sets it as the last error so that recordings know that error occurred. This PR also removes partially finished work to propagate pipe creation errors to users of the pipe. We will not need pipes for much longer, and this functionality wasn't complete anyway. Differential Revision: [D78683472](https://our.internmc.facebook.com/intern/diff/D78683472/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78683472/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78683472 |
…handling" This PR introduces a SeqError type which represents the 'root' seq that failed, clearly delinated from dependent errors in the type system. env objects are now changed to hold Arc<SeqError> with the lookup functions always returning a DependentError of the seq error. This makes it clear that our error type does not nest dependent errors, and it makes it clear where function invocation errors first get introduced. I use this to introduce a single place that creates the Arc<SeqError>, reports the error to the controller, and sets it as the last error so that recordings know that error occurred. This PR also removes partially finished work to propagate pipe creation errors to users of the pipe. We will not need pipes for much longer, and this functionality wasn't complete anyway. Differential Revision: [D78683472](https://our.internmc.facebook.com/intern/diff/D78683472/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78683472/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78683472 |
…handling" This PR introduces a SeqError type which represents the 'root' seq that failed, clearly delinated from dependent errors in the type system. env objects are now changed to hold Arc<SeqError> with the lookup functions always returning a DependentError of the seq error. This makes it clear that our error type does not nest dependent errors, and it makes it clear where function invocation errors first get introduced. I use this to introduce a single place that creates the Arc<SeqError>, reports the error to the controller, and sets it as the last error so that recordings know that error occurred. This PR also removes partially finished work to propagate pipe creation errors to users of the pipe. We will not need pipes for much longer, and this functionality wasn't complete anyway. Differential Revision: [D78683472](https://our.internmc.facebook.com/intern/diff/D78683472/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78683472/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78683472 |
|
This pull request has been merged in 45f2585. |
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR introduces a SeqError type which represents the 'root' seq that failed, clearly delinated from dependent errors in the type system.
env objects are now changed to hold Arc with the lookup functions always returning a DependentError of the seq error.
This makes it clear that our error type does not nest dependent errors, and it makes it clear where function invocation errors first get introduced.
I use this to introduce a single place that creates the Arc, reports the error to the controller, and sets it as the last error so that recordings know that error occurred.
This PR also removes partially finished work to propagate pipe creation errors to users of the pipe. We will not need pipes for much longer, and this functionality wasn't complete anyway.
Differential Revision: D78683472
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!