[23/n] tensor engine, implement rref on actor endpoints #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! [ghstack-poisoned]
This was referenced Jul 22, 2025
facebook-github-bot
added
the
CLA Signed
zdevito
added a commit
that referenced
this pull request
Jul 23, 2025
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! ghstack-source-id: 297921095 Pull Request resolved: #625
|
This pull request was exported from Phabricator. Differential Revision: D78782587 |
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 23, 2025
Pull Request resolved: #625 Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! ghstack-source-id: 298066447
|
This pull request was exported from Phabricator. Differential Revision: D78782587 |
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 23, 2025
Pull Request resolved: #625 Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. ghstack-source-id: 298177101 Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)!
|
This pull request was exported from Phabricator. Differential Revision: D78782587 |
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 24, 2025
Pull Request resolved: #625 Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. ghstack-source-id: 298207691 Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)!
|
This pull request was exported from Phabricator. Differential Revision: D78782587 |
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 24, 2025
Pull Request resolved: #625 Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. ghstack-source-id: 298227639 Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)!
|
This pull request was exported from Phabricator. Differential Revision: D78782587 |
This was referenced Jul 24, 2025
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 25, 2025
Pull Request resolved: #625 Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects. Actor endpoints that do this must have a propagator function defined. "cached" does not currently work because the caching machinery cannot make the actor call. Introduces `as_endpoint()` which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it. ghstack-source-id: 298650755 Differential Revision: [D78782587](https://our.internmc.facebook.com/intern/diff/D78782587/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78782587/)!
|
This pull request was exported from Phabricator. Differential Revision: D78782587 |
|
This pull request has been merged in e579c25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Allows actor endpoints to take tensors as arguments and return them as monarch.Tensor objects.
Actor endpoints that do this must have a propagator function defined.
"cached" does not currently work because the caching machinery cannot make the actor call.
Introduces
as_endpoint()which can take something that was not annotated on a class and turn it into an endpoint. This is useful when needing to define a per-actor propagation function for rref calls because there otherwise is nowhere to put it.Differential Revision: D78782587
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!