Skip to content

[22/n] tensor engine, Move Endpoint to its own file, move propagator to endpoint #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented Jul 22, 2025

Stack from ghstack (oldest at bottom):

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The @endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: D78771395

…to endpoint

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The @endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 22, 2025
zdevito added a commit that referenced this pull request Jul 22, 2025
…to endpoint

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

ghstack-source-id: 297884727
Pull Request resolved: #624
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78771395

…propagator to endpoint"

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Jul 22, 2025
…to endpoint

Pull Request resolved: #624

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The @endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)
ghstack-source-id: 297884965
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78771395

…propagator to endpoint"

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78771395

…propagator to endpoint"

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78771395

…propagator to endpoint"

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78771395

…propagator to endpoint"

This splits Endpoint into its own file since it is gaining more functionality.
Propagator rules, which previously were attached to Remote, a subclass of Endpoint, are now defined on Endpoint. The endpoint annotation can now take a propagator argument just like a remote. Since some propagators require the tensor engine, this introduces a shim through which that functionality can be accesssed.

Differential Revision: [D78771395](https://our.internmc.facebook.com/intern/diff/D78771395/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78771395

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ea27368.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants