Delete copy constructor and copy and move operators #2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikishor
added
the
backport-jazzy
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
harderthan,
Maverobot,
Raivias and
rosterloh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2378 +/- ##
==========================================
+ Coverage 88.84% 88.87% +0.03%
==========================================
Files 148 148
Lines 16893 16892 -1
Branches 1438 1439 +1
==========================================
+ Hits 15008 15013 +5
+ Misses 1319 1315 -4
+ Partials 566 564 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
previously approved these changes
Jul 10, 2025
|
@saikishor fyi: pre-commit is failing |
bmagyar
dismissed stale reviews from christophfroehlich and themself
via
e1f1029
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
(cherry picked from commit b315f2b) # Conflicts: # hardware_interface/include/hardware_interface/actuator.hpp # hardware_interface/include/hardware_interface/sensor.hpp # hardware_interface/include/hardware_interface/system.hpp
bmagyar
pushed a commit
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add changes based on rule of five. Shouldn't affect anything