-
Notifications
You must be signed in to change notification settings - Fork 998
Show import promo in autofill management #6266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show import promo in autofill management #6266
Conversation
eab8cdc
to
f64372f
Compare
f64372f
to
f0558c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds promotional functionality to the autofill management UI by showing or hiding a promo for importing passwords, along with the related business logic and test updates. Key changes include introducing a Lottie animation view in the message CTA, updating pixel tracking parameters and import launch source references, and implementing the logic and tests for tracking import promo display conditions.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
common/common-ui/src/main/res/layout/view_remote_message_cta.xml | Added LottieAnimationView and adjusted view hierarchy for promo animation. |
common/common-ui/src/main/java/com/duckduckgo/common/ui/view/MessageCta.kt | Refactored top illustration configuration to incorporate animations. |
autofill/* | Updated tests, pixel parameter values, and introduced new properties/methods for tracking “hasEverImportedPasswords” and promo dismissal. |
autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/promo/* | Added new classes and view models for managing the import promo visibility and user interactions. |
autofill/autofill-impl/build.gradle | Added a dependency on the Lottie library. |
autofill-api/* | Updated the AutofillFeature interface with a new toggle for promoting import passwords. |
Comments suppressed due to low confidence (1)
autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/importing/CredentialImporterImplTest.kt:118
- Verifying property setter calls via assignment (e.g. verify(autofillStore).hasEverImportedPasswords = true) may not be reliably supported by your mocking framework. Consider using an argument captor or directly asserting the state change on the store after the operation.
verify(autofillStore).hasEverImportedPasswords = true
...pl/src/main/java/com/duckduckgo/autofill/impl/importing/promo/ImportInPasswordsVisibility.kt
Show resolved
Hide resolved
...ain/java/com/duckduckgo/autofill/impl/importing/promo/ImportInPasswordsPromotionViewModel.kt
Show resolved
Hide resolved
...ain/java/com/duckduckgo/autofill/impl/importing/promo/ImportInPasswordsPromotionViewModel.kt
Show resolved
Hide resolved
common/common-ui/src/main/java/com/duckduckgo/common/ui/view/MessageCta.kt
Show resolved
Hide resolved
c5b9a14
to
4a20d39
Compare
4a20d39
to
6328d9a
Compare
6328d9a
to
f7556c0
Compare
return canShowImportPasswords | ||
} | ||
|
||
companion object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: consider making this private, since none of the constants are exposed. This avoids surfacing a public Companion
unnecessarily.
f7556c0
to
1347464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmonfortep @CDRussell these changes look good to me from ADS perspective. Just wondering, why not add this functionality to the local message too? Not a blocker, just a question.
1347464
to
92e9ebd
Compare
92e9ebd
to
75b8e66
Compare
Merge activity
|
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1210598549117736?focus=true
Description
Includes:
Steps to test this PR
Showing the promo
autofill_import_google_passwords_import_button_shown
withsource = passwords_management_promo
autofill_import_google_passwords_import_button_tapped_android_phone
withsource = passwords_management_promo
Dismiss
Complete import
(To test this better go to
RealImportInPasswordsVisibility
change MAX_PASSWORDS_TO_SHOW_PROMO to 5k , just a random big number. This is so we make sure we hide the promo because import happened, and not because number of passwords is >25)Complete import (different entry point)
(Keep the hardcoded value)
max 25 passwords
(Remove any hardcoded values)
FF disabled
(Remove any hardcoded values)
canPromoteImportPasswords
UI changes