Skip to content

Rename feature flag, to allow for separate flags for each password import promo #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jun 25, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1210639532381271?focus=true

Description

Renames feature flag for password import promo in password management screen (will introduce another for password import promo in browser)

Steps to test this PR

  • qa optional

@CDRussell
Copy link
Member Author

Will need to tweak ImportInPasswordsVisibility in higher PR (when there is the second promo) but just renaming that existing flag for now

@CDRussell CDRussell force-pushed the feature/craig/promo_import_add_icon_to_promo_cta_button branch from ca959e1 to ddfa495 Compare June 26, 2025 14:00
@CDRussell CDRussell force-pushed the feature/craig/promo_import_rename_feature_flag_name branch from a036140 to 6cacbe2 Compare June 26, 2025 14:00
@CDRussell CDRussell force-pushed the feature/craig/promo_import_rename_feature_flag_name branch from 6cacbe2 to f54f895 Compare June 27, 2025 13:07
@CDRussell CDRussell force-pushed the feature/craig/promo_import_add_icon_to_promo_cta_button branch from ddfa495 to 2810712 Compare June 27, 2025 13:07
@CDRussell CDRussell force-pushed the feature/craig/promo_import_add_icon_to_promo_cta_button branch from 2810712 to a5b7e49 Compare July 1, 2025 11:05
@CDRussell CDRussell force-pushed the feature/craig/promo_import_rename_feature_flag_name branch from f54f895 to 5153178 Compare July 1, 2025 11:05
Copy link
Member Author

CDRussell commented Jul 2, 2025

Merge activity

  • Jul 2, 9:09 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 2, 9:59 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 2, 10:13 AM UTC: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell changed the base branch from feature/craig/promo_import_add_icon_to_promo_cta_button to graphite-base/6293 July 2, 2025 09:41
@CDRussell CDRussell changed the base branch from graphite-base/6293 to develop July 2, 2025 09:56
@CDRussell CDRussell force-pushed the feature/craig/promo_import_rename_feature_flag_name branch from 5153178 to 224662e Compare July 2, 2025 09:58
@CDRussell CDRussell merged commit d5b6cb5 into develop Jul 2, 2025
7 checks passed
@CDRussell CDRussell deleted the feature/craig/promo_import_rename_feature_flag_name branch July 2, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants