Skip to content

Change requirement for marking a previous password import as having happened #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jun 24, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1210619659166977?focus=true

Description

Changes the requirements around how many passwords must be imported to mark a previous import as having happened.

  • Before: we required 1 or more passwords were imported
  • Now: we require that the user has finished the import flow, regardless of the number of credentials imported.

Steps to test this PR

  • QA optional

@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_skip_preimport_screen branch from 3763867 to 2f66be7 Compare June 24, 2025 16:00
@CDRussell CDRussell force-pushed the feature/craig/promo_import_remove_number_passwords_imported_requirement branch from efd8d6f to c15fc94 Compare June 24, 2025 16:00
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_skip_preimport_screen branch from 2f66be7 to ee5d7b2 Compare June 25, 2025 11:21
@CDRussell CDRussell force-pushed the feature/craig/promo_import_remove_number_passwords_imported_requirement branch from c15fc94 to 8ce1d87 Compare June 25, 2025 11:21
@CDRussell CDRussell force-pushed the feature/craig/promo_import_remove_number_passwords_imported_requirement branch from 8ce1d87 to a97d09d Compare June 26, 2025 14:00
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_skip_preimport_screen branch from ee5d7b2 to 839a426 Compare June 26, 2025 14:00
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_skip_preimport_screen branch from 839a426 to ebc6508 Compare June 27, 2025 13:07
@CDRussell CDRussell force-pushed the feature/craig/promo_import_remove_number_passwords_imported_requirement branch from a97d09d to 40d3cc5 Compare June 27, 2025 13:07
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_skip_preimport_screen branch from ebc6508 to 40c2bee Compare July 1, 2025 11:05
@CDRussell CDRussell force-pushed the feature/craig/promo_import_remove_number_passwords_imported_requirement branch from 40d3cc5 to 291ced9 Compare July 1, 2025 11:05
Copy link
Member Author

CDRussell commented Jul 2, 2025

Merge activity

  • Jul 2, 9:09 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 2, 9:28 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 2, 9:40 AM UTC: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell changed the base branch from feature/craig/autofill/promo_import_skip_preimport_screen to graphite-base/6281 July 2, 2025 09:10
@CDRussell CDRussell changed the base branch from graphite-base/6281 to develop July 2, 2025 09:25
@CDRussell CDRussell force-pushed the feature/craig/promo_import_remove_number_passwords_imported_requirement branch from 291ced9 to 9aca7a7 Compare July 2, 2025 09:27
@CDRussell CDRussell merged commit 2e03365 into develop Jul 2, 2025
7 checks passed
@CDRussell CDRussell deleted the feature/craig/promo_import_remove_number_passwords_imported_requirement branch July 2, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants